fixup! Support for Tor onion services (#736)

[pm47]

No description provided.

[codecov-io]

Codecov Report

Merging #1356 into master will increase coverage by 0.12%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   86.29%   86.41%   +0.12%     
==========================================
  Files         119      119              
  Lines        9201     9202       +1     
  Branches      396      390       -6     
==========================================
+ Hits         7940     7952      +12     
+ Misses       1261     1250      -11     

Impacted Files	Coverage Δ
...n/scala/fr/acinq/eclair/tor/Socks5Connection.scala	3.33% <0.00%> (ø)
...ore/src/main/scala/fr/acinq/eclair/io/Client.scala	62.79% <50.00%> (-1.50%)	⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala	85.55% <0.00%> (+0.36%)	⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala	89.76% <0.00%> (+1.57%)	⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala	82.79% <0.00%> (+4.30%)	⬆️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala	94.87% <0.00%> (+5.12%)	⬆️

[t-bast]

It's a bit worrisome that we're lacking tests and didn't catch that earlier 😕

[pm47]

It's a bit worrisome that we're lacking tests and didn't catch that earlier

We're indeed missing automated tests with an actual tor instance, there is only a manual test. On the bright side, the impact was only in logging.