Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feerate provider improvements #1415

Merged
merged 4 commits into from
May 13, 2020
Merged

Feerate provider improvements #1415

merged 4 commits into from
May 13, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented May 11, 2020

  • Use ConstantFeeProvider only on regtest: it doesn't make sense to fallback to hardcoded feerates on testnet/mainnet, better to stick with the one we previously used
  • Fail bootstrap if we cannot retrieve feerates: this will prevent some unnecessary channel closing when starting eclair-mobile with a crappy connection
  • Increase feerate providers timeout: 5 seconds was a bit aggressive for mobile connections

@t-bast t-bast requested review from dpad85 and pm47 May 11, 2020 16:19
pm47
pm47 reviewed May 13, 2020
View reviewed changes
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent change, agree with @dpad85's comment but otherwise LGTM.

@t-bast t-bast merged commit f22ec21 into master May 13, 2020
@t-bast t-bast deleted the feerate-provider-improvements branch May 13, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpad85 dpad85 dpad85 left review comments

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-bast @pm47 @dpad85