-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electrum: stop spamming logs #1433
Conversation
…a proper handshake We only care for errors that we received during or after the "handshake" (i.e. the exchange of "version" messages). Other errors cause by dead/unresponsive servers... which are very common on testnet just add spams to the logs.
…ry servers We care for errors with our master electrum servers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, how do we review/validate the updated checkpoints?
The checkpoints are imported from Electrum (we use the exact same format), these come from spesmilo/electrum@fc80f7a They are block hashes and difficulty targets taken every 2016 blocks (which is the difficulty adjustment period). They can be checked manually:
For example the last item on our mainnet checkpoint is:
The corresponding block header is:
And the
We can check that it matches the
|
Connection errors that happen before a proper handshake (i.e exchange of "version" messages) has been completed are now logged as "debug". Errors that are not sent by our master Electrum server are also logged as debug.
This greatly reduces the amount of connection-related logs, especially on testnet, and users will still be able to tell if they have connection issues (tested with eclair-mobile and Phoenix).
The last commit updates our electrum checkpoints.