Routing hints balance #1443
Merged
Routing hints balance #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assume that twice the payment amount can be routed through the channel for extra safety.
t-bast
force-pushed
the
routing-hints-balance
branch
from
d4fea18 to
e9c5878
Compare
pm47
reviewed
Jun 23, 2020
| @@ -109,7 +109,7 @@ object RouteCalculation { | |||
| // should be able to route the payment, so we'll compute an htlcMaximumMsat accordingly. | |||
| // We could also get the channel capacity from the blockchain (since we have the shortChannelId) but that's more expensive. | |||
| // We also need to make sure the channel isn't excluded by our heuristics. | |||
| val lastChannelCapacity = amount.max(RoutingHeuristics.CAPACITY_CHANNEL_LOW) | |||
| val lastChannelCapacity = (amount * 2).max(RoutingHeuristics.CAPACITY_CHANNEL_LOW) | |||
There was a problem hiding this comment.
I'm not sure about this, except if we have a real reason behind this change.
There was a problem hiding this comment.
This indeed shouldn't be necessary, I reverted it in aaf17b6
This reverts commit 7637242.
pm47
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of several small fixes/improvements: