Fix edges with empty capacity in the routing graph #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Light clients don't always validate channels by fetching the blockchain tx. That means they don't have access to the exact capacity. When that happens, we can fallback to htlc_maximum_msat if available, or to a default capacity (otherwise path-finding will ignore these edges).
|
LGTM, but it's a bit difficult to test as I don't think it's covered by our unit tests yet (on master capacity is correct as we get it from the blockchain, on android it's not but "A->B->C" type tests are disabled as we don't relay payments which is why this issue was not detected before, and on phoenix it's not relevant). |
|
Actually this doesn't cover all the way we can create the graph. Wait before testing on android, I need to add another commit to cover everything. |
|
You should be good now, I was missing the helper method we use to create the graph initially from the DB. |
sstone
approved these changes
Jun 5, 2020
|
I checked that it does fix route computation on Android. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light clients don't always validate channels by fetching the blockchain tx.
That means they don't have access to the exact capacity.
When that happens, we should fallback to
htlc_maximum_msatif available, or to a default capacity (otherwise path-finding will ignore these edges).