Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back DATA_CLOSING constraints #1462

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Put back DATA_CLOSING constraints #1462

merged 1 commit into from
Jun 19, 2020

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Jun 19, 2020

We go to the CLOSING if and only if the funding tx has been spent by
one transaction. The require is absolutely necessary. We could
probably enforce this constraint at the compilation level by more clever
typing but that's another matter.

We go to the `CLOSING` if and only if the funding tx has been spent by
one transaction. The `require` is absolutely necessary. We could
probably enforce this constraint at the compilation level by more clever
typing but that's another matter.
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I re-read the static_remotekey PR and I don't see the reason why we removed that requirement.

@pm47 pm47 merged commit 59ea4cd into master Jun 19, 2020
@pm47 pm47 deleted the data-closing-contraints branch June 19, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants