Static key refactoring #1463
Merged
Static key refactoring #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `getOrElse` on the option value to decide between static/dynamic payment point, instead of the `ChannelVersion` bit.
Also reduce visibility of a few members of `ChannelVersion`, and some cleanup.
sstone
reviewed
Jun 19, 2020
| case v if v.isSet(USE_STATIC_REMOTEKEY_BIT) => localParams.localPaymentBasepoint.get | ||
| case _ => keyManager.paymentPoint(channelKeyPath).publicKey | ||
| } | ||
| val localPaymentBasepoint = localParams.staticPaymentBasepoint.getOrElse(keyManager.paymentPoint(channelKeyPath).publicKey) |
There was a problem hiding this comment.
it looks better, but now it does not check that localParams.staticPaymentBasepoint is defined iff channelVersion activates option_static_remote_key
There was a problem hiding this comment.
It kind of does, here:
I think that's consistent with how remote works: we just use the value they give us and assume it follows the static feature bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits description. They are independent and can be reviewed separately.