Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github action for scoverage #1490

Merged
merged 9 commits into from
Jul 21, 2020
Merged

Use github action for scoverage #1490

merged 9 commits into from
Jul 21, 2020

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Jul 20, 2020

No description provided.

@pm47 pm47 marked this pull request as ready for review July 20, 2020 15:16
@pm47 pm47 marked this pull request as draft July 20, 2020 15:22
@pm47 pm47 marked this pull request as ready for review July 20, 2020 15:57
@pm47 pm47 requested a review from dpad85 July 20, 2020 15:58
t-bast
t-bast reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the .codecov.yml file?
It was useful to remove the gui and node parts from code coverage.

@pm47
Copy link
Member Author

pm47 commented Jul 21, 2020

Why do you remove the .codecov.yml file?
It was useful to remove the gui and node parts from code coverage.

Because it didn't work when I was running the tests locally. Instead I use a directory filter when uploading the reports in the workflow.yml.

t-bast
t-bast approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead I use a directory filter when uploading the reports in the workflow.yml.

Ok, got it! LGTM

@pm47 pm47 merged commit aca7499 into master Jul 21, 2020
@pm47 pm47 deleted the codecov-action branch July 21, 2020 11:05
@pm47
Copy link
Member Author

pm47 commented Jul 21, 2020

Instead I use a directory filter when uploading the reports in the workflow.yml.

Except it's not working 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

@dpad85 dpad85 Awaiting requested review from dpad85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pm47 @t-bast