Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bitcoin Core 0.20.1 #1526

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Update to Bitcoin Core 0.20.1 #1526

merged 2 commits into from
Sep 8, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Sep 8, 2020

The only impactful change is that by default on regtest and testnet the fallbackfee (used when there is not enough historical data to correctly estimate the feerate) is now set to 0, whereas it was set to 0.0002 btc in previous versions. This change only impacts regtest and testnet, on mainnet this parameter has always been set to 0.

We set it manually in tests bitcoin.conf to preserve the past behavior (as recommended by bitcoind's release notes).

The only impactful change is that by default on regtest and testnet
fallback fee (used when there is not enough historical data to correctly
estimate the feerate) is now set to 0, whereas it was set to 0.0002 btc
in previous versions.

We set it manually in tests `bitcoin.conf` to make preserve the past behavior.
@t-bast t-bast marked this pull request as ready for review September 8, 2020 14:21
@t-bast t-bast requested review from sstone and pm47 September 8, 2020 14:21
pm47
pm47 previously approved these changes Sep 8, 2020
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified all the checksums ✔️

Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're not into oxford comma.

@t-bast
Copy link
Member Author

t-bast commented Sep 8, 2020

I'm too biased by french grammar 😆

@t-bast t-bast merged commit b954def into master Sep 8, 2020
@t-bast t-bast deleted the bitcoind-0.20.1 branch September 8, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants