Make all commands extend Has*ReplyToCommand
#1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Sep 28, 2020
eclair-core/src/main/scala/fr/acinq/eclair/wire/CommandCodecs.scala
Outdated
Show resolved
Hide resolved
| @@ -68,7 +68,10 @@ class WaitForFundingCreatedInternalStateSpec extends TestKitBaseClass with Fixtu | |||
|
|
|||
| test("recv CMD_CLOSE") { f => | |||
| import f._ | |||
| alice ! CMD_CLOSE(None) | |||
| val sender = TestProbe() | |||
| val c = CMD_CLOSE(sender.ref, None) | |||
There was a problem hiding this comment.
Should we have one of these tests test the fallback to sender when ActorRef.noSender is provided?
val sender = TestProbe()
val c = CMD_CLOSE(ActorRef.noSender, None)
sender.send(alice, c)
sender.expectMsg(RES_SUCCESS(c, ByteVector32.Zeroes))
awaitCond(alice.stateName == CLOSED)There was a problem hiding this comment.
Done with 2bad181... and found a bug!
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/f/ShutdownStateSpec.scala
Show resolved
Hide resolved
t-bast
previously approved these changes
Sep 29, 2020
This way we can maintain replies in tests.
I'm not sure how we could prevent extending `Command` directly.
pm47
force-pushed
the
channel-cmd-optional-replyto
branch
from
7f01183 to
da98eff
Compare
t-bast
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands have to be of type
HasReplyToCommandorHasOptionalReplyToCommand. The latter is mostly for commands which don't need replies except in tests.With this change, there is no more
replyinginChannel, and a lot ofsender.send()have been removed from tests, in preparation to full akka typed.Supersedes #1533.