Separate configuration for peer-connection #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features are now provided by the `switchboard`, in response to the `PeerConnection.Authenticated` message. The `switchboard` will also decide whether or not we sync with that peer, depending on the `syncWhiteList` configuration.
t-bast
reviewed
Oct 2, 2020
eclair-core/src/test/scala/fr/acinq/eclair/io/PeerConnectionSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features are now provided by the
switchboard, in response to thePeerConnection.Authenticatedmessage.The
switchboardwill also decide whether or not we sync with thatpeer, depending on the
syncWhiteListconfiguration.This is an alternative to #1361. The
features/override-features/sync-whitelistremain top-level parameters ineclair.conf, which was one of the main issues with #1361.