Remove timedOutOutgoingHtlcs
from AbstractCommitments
#1604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that:
def timedOutOutgoingHtlcs(blockHeight: Long): Set[wire.UpdateAddHtlc]
defined inAbstractCommitments
is currently only used inCommitments
object and nowhere else.timedOutOutgoingHtlcs
takes additional arguments besidesblockHeight
.So it makes sense to just remove
timedOutOutgoingHtlcs
fromAbstractCommitments
and let HC commitments object to do things differently internally without implementing of (useless)timedOutOutgoingHtlcs
.