Rename pending_relay to pending_commands #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naming was confusing because it led to believe messages were related to htlcs that have not yet been relayed, whereas those are settlement messages, meaning that htlcs have relayed and are pending resolution upstream. The database has been renamed to a more generic `PendingCommandsDb` because we may store other types of commands for which we need reliable delivery.
t-bast
reviewed
May 25, 2021
eclair-core/src/test/scala/fr/acinq/eclair/db/PendingCommandsDbSpec.scala
Show resolved
Hide resolved
t-bast
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming was confusing because it led to believe messages were related to
htlcs that have not yet been relayed, whereas those are settlement
messages, meaning that htlcs have been relayed and are pending resolution
upstream.
The database has been renamed to a more generic
PendingCommandsDbbecause we may store other types of commands for which we need reliable
delivery.