Make result set an iterable #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to use the full power of scala collections, to iterate over results, convert to options, etc. while staying purely functional and immutable. There is a catch though: the iterator is lazy, it must be materialized before the result set is closed, by converting the end result in a collection or an option. In other words, database methods must never return an `Iterable` or `Iterator`.
Codecov Report
@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
- Coverage 89.39% 89.35% -0.05%
==========================================
Files 145 145
Lines 11034 10973 -61
Branches 456 457 +1
==========================================
- Hits 9864 9805 -59
+ Misses 1170 1168 -2
|
t-bast
reviewed
May 25, 2021
eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgNetworkDb.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqliteNetworkDb.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use the full power of scala collections, to iterate
over results, convert to options, etc. while staying purely functional
and immutable.
There is a catch though: the iterator is lazy, it must be materialized
before the result set is closed, by converting the end result in a
collection or an option. In other words, database methods must never
return an
IterableorIterator.