Remove invalid channel updates from DB at startup #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #2361, we reject channel updates that don't contain the `htlc_maximum_msat` field. However, the network DB may contain such channel updates, that we need to remove when starting up.
sstone
reviewed
Aug 11, 2022
eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgNetworkDb.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqliteNetworkDb.scala
Outdated
Show resolved
Hide resolved
sstone
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2361, we reject channel updates that don't contain the
htlc_maximum_msatfield. However, the network DB may contain such channel updates, that we need to remove when starting up.I've checked what we have in our network DB on the ACINQ node before opening that PR. We have ~100 channel updates that don't contain an
htlc_maximum_msat, but all of them except one are completely outdated (from before 2020), which indicates that we have a pruning bug that I'll fix in a separate PR. The only non-outdated invalid channel update that we have is a 22,222 sat channel between a node calleddontconnectand a node calledSybil: https://1ml.com/channel/588047405915373568So we can pretty much ignore it.