Add tlv stream to onion failures #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
onion-error-tlv-stream
branch
from
2c57857
to
9bbe335
Compare
t-bast
referenced
this pull request
Nov 7, 2022
The specification recommends using a length of 256 for onion errors, but it doesn't say that we should reject errors that use a different length. We may want to start creating errors with a bigger length than 256 if we need to transmit more data to the sender. In order to prepare for this, we keep creating 256-bytes onion errors, but allow receiving errors of arbitrary length. See the specification here: lightning/bolts#1021 Fixes #2438
t-bast
force-pushed
the
onion-error-tlv-stream
branch
from
9bbe335
to
755ad64
Compare
t-bast
force-pushed
the
onion-error-tlv-stream
branch
from
755ad64
to
9167012
Compare
Extend every onion failure with an optional tlv stream. See the specification here: lightning/bolts#1021
t-bast
force-pushed
the
onion-error-tlv-stream
branch
from
9167012
to
f67f23c
Compare
pm47
reviewed
Jan 3, 2023
eclair-core/src/main/scala/fr/acinq/eclair/payment/send/PaymentInitiator.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/CommandCodecs.scala
Show resolved
Hide resolved
pm47
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend every onion failure with an optional tlv stream, as specified here: lightning/bolts#1021
I have verified cross-compatibility with lnd (lightningnetwork/lnd#6967) in both directions (reading and writing a tlv stream) and the spec PR has been merged, so this is ready to integrate.