Fix blinded path min_final_expiry_delta
check
#2678
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says that we must return an error if:
For the second check, we actually tested if:
But that check should only verify that our
min_final_expiry_delta
requirement is fulfilled, which is unrelated to theoutgoing_cltv_value
.It was redundant with the first check, which already guarantees that intermediate nodes inside the blinded path cannot cheat by using a higher
cltv_expiry_delta
than what the recipient intended.For context, see lightning/bolts#1066 and https://gist.github.com/t-bast/b1371d357a2c5f3e8c09514a62db7079