Use sttp lib instead of akka-http-client #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the tests are failing, we are using the correct |
|
Actually I think that sttp might be the way to go: it has the same advantages as gigahorse (pluggable backend), and seems to have more traction. |
Also replaced json4s.jackson by json4s.native and cleaned up Setup implicits.
pm47
changed the title
|
We need to make sure that it works on Android too (including the switch from json4s-jackson to json4s-native) |
|
@sstone I reverted back to json4s-jackson so there shouldn't be any problems |
See branch android-merge-gigahorse |
sstone
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would reduce the difference between master/android branches (we are currently using akka-http-client on master and async-http-client on android).
Also, this would hopefully fix the
got exception for batch of 1 requestsakka.http.impl.engine.client.OutgoingConnectionBlueprint$UnexpectedConnectionClosureException: The http server closed the connection unexpectedly before delivering responses for 1 outstanding requestserror.