Proper handling of gossiped channels being spent #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it makes sense to exclude from the routing table channels for which there is a spending tx in the mempool, we shouldn't blame our peers for considering the channel still opened if the spending tx hasn't yet been confirmed. Also, reworked `ValidateResult` with better types. It appears that the `NonexistingChannel` error wasn't really useful (a malicious peer would probably point to an existing funding tx, so there is no real difference between "txid not found" and "invalid script"), so it was replaced by `InvalidAnnouncement` error which is a more serious offense (punished by a disconnection, and probably a ban when we implement that sort of things).
pm47
force-pushed
the
validate-mempool
branch
from
b725826 to
e368770
Compare
sstone
reviewed
Jan 29, 2019
| case object Unspent extends UtxoStatus | ||
| case object Spent extends UtxoStatus | ||
| case object SpentAndSpendingTxConfirmed extends UtxoStatus | ||
| } |
There was a problem hiding this comment.
Nitpick: why not case class Spent(confirmed:Boolean) instead ?
sstone
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it makes sense to exclude from the routing table channels for
which there is a spending tx in the mempool, we shouldn't blame our
peers for considering the channel still opened if the spending tx hasn't
yet been confirmed.
Also, reworked
ValidateResultwith better types. It appears that theNonexistingChannelerror wasn't really useful (a malicious peer wouldprobably point to an existing funding tx, so there is no real difference
between "txid not found" and "invalid script"), so it was replaced by
InvalidAnnouncementerror which is a more serious offense (punishedby a disconnection, and probably a ban when we implement that sort of
things).