Use bitcoin-lib 0.11 which embeds libsecp256k1 #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use a version of bitcoin-lib which embeds JNI bindings for libsecp256k1, and it will only sign data that is 32 bytes long (in Bitcoin and LN you always sign data hashes, not the actual data).
pm47
previously approved these changes
Mar 20, 2019
…ver" This reverts commit 46f89b3.
We don't need to generate 432 blocks to activate segwit but we still need to have spendable coins and coinbase maturity is 100 blocks even on regtest.
…et server We already test against a real Electrum server in our docker tests.
Previous test against testnet servers was flaky because testnet Electrum servers are unrelable. Here we test against our own server on mainnet (and 2 servers from our list for the pool test).
This reverts commit 1a8f348.
We called nodeParams which created a new in-memory sqlite database everytime we created "fake" routing info
Creating funding tx is now faster since we call libsecp256k1 and we may miss the transition to WAIT_FOR_FUNDING_INTERNAL and see WAIT_FOR_FUNDING_SIGNED instead. For this test, we use a dummy wallet that will never return a funding tx.
Same fix as for WaitForFundingCreatedInternalStateSpec
pm47
previously approved these changes
Mar 25, 2019
pm47
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades bitcoin-lib to version 0.11 which embeds native bindings for libsecp256k1 (for Linux 64 bits, Windows 64 bits and Osx 64 bits), which will be added to our "capsule" jar. Most users will benefit from this (much faster eclair nodes) without having to do anything.