This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
[iOS] Feat/review storage #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests were not building properly, changed settings to have them running as expected
Set a dummy `ContentView` for add to prevent being tricked by application init logic. Added basic test that insert in keyChain and read results back
Added basic unit tests to check store read works as expected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added small tests to ensure storage does not suffer from regressions, these tests are simple and only work "properly" on device with TouchId (where we can enroll from code).
This can pave the way for iOS tests as there were not enabled (rather than the autogenerated stub from xcode).
Feel free to dump this branch if this is not relevant.