Build a universal JNI binary for macos #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
force-pushed
the
snapshot/macos-universal-lib
branch
from
e62e3ab to
0391564
Compare
Universal libraries embed both arm64 and x64 binaries.
sstone
force-pushed
the
snapshot/macos-universal-lib
branch
from
0391564 to
964ae2f
Compare
t-bast
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal libraries embed both arm64 and x64 binaries, and are built on our CI.
This makes our build and release process simpler, as we no longer need to build macos arm64 JNI libs "manually" on a mac M1/M2.