-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update secp256k1 submodule #107
Conversation
e23a77b
to
2a3badd
Compare
565a679
to
62afbc8
Compare
I don't think we need to merge any update to the libsecp256k1 submodule until they officially ship musig2. I'd rather wait for the musig2 PR to be merged on their side before we update to a "final" version. |
We can wait. The musig2 branch that we use is behind secp2561k1's musig2 PR but there are only minor changes and an API change (counter-based nonce generation). I hope it will be released soon though :) |
7b1e117
to
c5b66d3
Compare
We're now at 461970682f56a8e15fc71ecab18d4537e50441fc.
cea19a3
to
453fceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me, we should make a release now that we depend on an official release of secp256k1! However it looks like you're still pointing the submodule to jonasnick
's fork of the repository, can you fix it and point it to https://github.com/bitcoin-core/secp256k1?
Done in 6a68a9d |
Counter-based nonce generation has been extracted into a separate method.