Products at different hierarchy levels #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for scenarios where device hierarchies with different depths have product allocations assigned.
For example, liquid product is applied through Function->Boom->Unit and dry product through Function->Boom->Section->Unit. Previous logic would determine the lowest level from hierarchy for dry product (which is 4) and then filter out liquid product hierarchy (which has lowest level of 3). The end result is missing separate operation for liquid product.
The new logic keeps hierarchy of the same type (Unit) when leaf device element has not children. This results in two operation being created: one for liquid and one for dry products.