LibWeb/WebGL: Don't crash on unknown getParameter on the context

And allow the implementation to set the error code.
ADKaster · Dec 6, 2024 · aa5f94c · aa5f94c
1 parent 9becc62
commit aa5f94c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Libraries/LibWeb/WebGL/WebGL2RenderingContext.h b/Libraries/LibWeb/WebGL/WebGL2RenderingContext.h
@@ -73,7 +73,7 @@ class WebGL2RenderingContext : public Bindings::PlatformObject
 
     GLenum m_error { 0 };
 
-    void set_error(GLenum error);
+    virtual void set_error(GLenum error) override;
 };
 
 }
diff --git a/Libraries/LibWeb/WebGL/WebGLRenderingContext.h b/Libraries/LibWeb/WebGL/WebGLRenderingContext.h
@@ -72,7 +72,7 @@ class WebGLRenderingContext : public Bindings::PlatformObject
 
     GLenum m_error { 0 };
 
-    void set_error(GLenum error);
+    virtual void set_error(GLenum error) override;
 };
 
 void fire_webgl_context_event(HTML::HTMLCanvasElement& canvas_element, FlyString const& type);

diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateWebGLRenderingContext.cpp
@@ -231,7 +231,9 @@ static void generate_get_parameter(SourceGenerator& generator)
 
     generator.appendln(R"~~~(
     default:
-        TODO();
+        dbgln("Unknown WebGL parameter name: {:x}", pname);
+        set_error(GL_INVALID_ENUM);
+        return JS::js_null();
     })~~~");
 }
 
@@ -389,6 +391,7 @@ class @class_name@ {
 
     virtual void present() = 0;
     virtual void needs_to_present() = 0;
+    virtual void set_error(GLenum) = 0;
 )~~~");
 
     for (auto const& function : interface.functions) {