Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback not triggering during the animation playback #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix callback not triggering during the animation playback #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79e557e
Fix callback not triggering during the animation playback
iamsleepy Dec 12, 2016
87f09a3
Update affectsNode.cpp
iamsleepy Dec 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions affectsNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,7 @@ class affects : public MPxNode

void setProjectionMatrixDirty();

friend void cameraAttributeChanged(MNodeMessage::AttributeMessage msg,
MPlug & plug,
MPlug & otherPlug,
void* userData );
friend void cameraNodePlugDirty(MObject &node, MPlug &plug, void *clientData);

friend void cameraWorldMatrixChangeCallback(MObject &transformNode,
MDagMessage::MatrixModifiedFlags &modified,
Expand Down Expand Up @@ -132,7 +129,7 @@ MStatus affects::compute( const MPlug& plug, MDataBlock& data )
return MStatus::kSuccess;
}

// Create an attribute change callback on the camera when connection is made
// Create a node plug dirty callback on the camera when connection is made
MStatus affects::connectionMade( const MPlug& plug, const MPlug& otherPlug, bool asSrc )
{
if(plug == inputCamera)
Expand All @@ -151,7 +148,7 @@ MStatus affects::connectionMade( const MPlug& plug, const MPlug& otherPlug, bool
MFnCamera fnCam(cameraNode);
projectionMatrixValue = fnCam.projectionMatrix();
setProjectionMatrixDirty();
cameraCallbackId = MNodeMessage::addAttributeChangedCallback(cameraNode, cameraAttributeChanged, this);
cameraCallbackId = MNodeMessage::addNodeDirtyPlugCallback(cameraNode, cameraNodePlugDirty, this);

// Add world transform matrix
MSelectionList sel;
Expand All @@ -166,7 +163,7 @@ MStatus affects::connectionMade( const MPlug& plug, const MPlug& otherPlug, bool
return MPxNode::connectionMade(plug, otherPlug, asSrc);
}

// Remove callback when connection is broken.
// Remove callbacks when connection is broken.
MStatus affects::connectionBroken( const MPlug& plug, const MPlug& otherPlug, bool asSrc )
{
if(plug == inputCamera)
Expand Down Expand Up @@ -211,8 +208,8 @@ MStatus affects::initialize()

// Use for projection matrix
projectionMatrix = matAttr.create(PROJECTION_MATRIX_LN, PROJECTION_MATRIX_SN, MFnMatrixAttribute::kFloat);
//matAttr.setInternal(true);


// Message attribute
inputCamera = msgAttr.create(INPUT_CAMERA_LN, INPUT_CAMERA_SN);

// For attributeAffects
Expand All @@ -227,13 +224,10 @@ MStatus affects::initialize()
return( MS::kSuccess );
}

// Attribute change callback
void cameraAttributeChanged(MNodeMessage::AttributeMessage msg,
MPlug & plug,
MPlug & otherPlug,
void* userData )
// Node plug dirty change callback
void cameraNodePlugDirty(MObject &node, MPlug &plug, void *clientData)
{
affects* affectNode = (affects*)userData;
affects* affectNode = (affects*)clientData;

if(affectNode->isCameraSet)
{
Expand Down