fix(body): add external type (#1039)

Co-authored-by: Rik Smale <WikiRik@users.noreply.github.com>
AEGEE · Dec 5, 2024 · fb4176b · fb4176b
1 parent c1a3e2f
commit fb4176b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/models/Body.js b/models/Body.js
@@ -62,13 +62,13 @@ const Body = sequelize.define('body', {
         allowNull: true,
     },
     type: {
-        type: Sequelize.ENUM('antenna', 'contact antenna', 'contact', 'interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'other'),
+        type: Sequelize.ENUM('antenna', 'contact antenna', 'contact', 'interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'external', 'other'),
         allowNull: false,
         defaultValue: 'antenna',
         validate: {
             isIn: {
-                args: [['antenna', 'contact antenna', 'contact', 'interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'other']],
-                msg: 'Type must be one of these: "antenna", "contact antenna", "contact", "interest group", "working group", "commission", "committee", "project", "partner", "other".'
+                args: [['antenna', 'contact antenna', 'contact', 'interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'external', 'other']],
+                msg: 'Type must be one of these: "antenna", "contact antenna", "contact", "interest group", "working group", "commission", "committee", "project", "partner", "external", "other".'
             }
         }
     },

diff --git a/scripts/seed.js b/scripts/seed.js
@@ -48,6 +48,7 @@ async function createBodies() {
         'Committee',
         'Project',
         'Partner',
+        'External',
         'Other'
     ];
 
@@ -61,6 +62,7 @@ async function createBodies() {
         'COT',
         'PRO',
         'PAR',
+        'EXT',
         'OTH'
     ];
 

diff --git a/test/api/bodies-creating.test.js b/test/api/bodies-creating.test.js
@@ -102,7 +102,7 @@ describe('Bodies creating', () => {
         });
     }
 
-    for (const type of ['interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'other']) {
+    for (const type of ['interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'external', 'other']) {
         test(`should succeed when foundation date is empty on ${type}`, async () => {
             const user = await generator.createUser({ username: 'test', mail_confirmed_at: new Date(), superadmin: true });
             const token = await generator.createAccessToken(user);

diff --git a/test/api/bodies-editing.test.js b/test/api/bodies-editing.test.js
@@ -183,7 +183,7 @@ describe('Bodies editing', () => {
         });
     }
 
-    for (const type of ['interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'other']) {
+    for (const type of ['interest group', 'working group', 'commission', 'committee', 'project', 'partner', 'external', 'other']) {
         test(`should succeed when foundation date is empty on ${type}`, async () => {
             const user = await generator.createUser({ superadmin: true });
             const token = await generator.createAccessToken(user);
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,6 +48,7 @@ async function createBodies() { @@
             'Committee',
             'Project',
             'Partner',
+            'External',
             'Other'
         ];
@@ Expand All / @@ -61,6 +62,7 @@ async function createBodies() { @@
             'COT',
             'PRO',
             'PAR',
+            'EXT',
             'OTH'
         ];
@@ Expand Down @@