fix(bodies): allow empty foundation date. Fixes HELP-1789 #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge1peshcoff
approved these changes
Oct 22, 2021
serge1peshcoff
approved these changes
Oct 22, 2021
WikiRik
commented
Oct 22, 2021
| @@ -246,6 +252,10 @@ export default { | |||
| this.body.founded_at = moment(this.foundationDate).format('YYYY-MM-DD') | |||
| }, | |||
| saveBody () { | |||
| if (['antenna', 'contact antenna', 'contact'].includes(this.body.type) && !this.body.founded_at) { | |||
There was a problem hiding this comment.
@serge1peshcoff this good enough? Or do you also want to check if it's a valid date?
There was a problem hiding this comment.
should work good I'd say
serge1peshcoff
pushed a commit
that referenced
this pull request
Oct 22, 2021
## [1.33.1](1.33.0...1.33.1) (2021-10-22) ### Bug Fixes * **bodies:** allow empty foundation date. Fixes HELP-1789 ([#1184](#1184)) ([b5a22f6](b5a22f6))
|
🎉 This PR is included in version 1.33.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed two issues with error messages when creating/editing bodies
Core PR for this is AEGEE/core#371