fix: functions issue in nft dapp #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)96.34%[docs/quick-start/developers/nft-dapp/index.md] |
yongenaelf
reviewed
Dec 26, 2024
| @@ -1042,10 +979,9 @@ const createNftToken = async (values: INftParams) => { | |||
| memo: "We are issuing nftToken", | |||
| }); | |||
| setTransactionStatus(false); | |||
| } catch (error: any) { | |||
| } catch (error) { | |||
| console.error(error, "=====error"); | |||
yongenaelf
reviewed
Dec 26, 2024
| @@ -1416,7 +1352,7 @@ const transferNftToOtherAccount = async (values: { | |||
| await delay(3000); | |||
|
|
|||
| handleReturnClick(); | |||
| } catch (error: any) { | |||
| } catch (error) { | |||
| console.error(error.message, "=====error"); | |||
yongenaelf
requested changes
Dec 26, 2024
| @@ -525,7 +511,7 @@ const GetParentChainHeight = async () => { | |||
| const result = await tdvwCrossChainContract.GetParentChainHeight.call() | |||
| // Return the parent chain height if it exists, otherwise return an empty string. | |||
| return result ? (result.value as string) : ""; | |||
| } catch (error: any) { | |||
| } catch (error) { | |||
| // If there's an error, log it and return an error status. | |||
| console.error(error, "=====error in GetParentChainHeight"); | |||
yongenaelf
reviewed
Jan 2, 2025
| ### 4.3 Create NFT Collection on dAppChain | ||
|
|
||
| :::tip | ||
| ℹ️ Note: This step cannot be executed via the command line interface (CLI). |
There was a problem hiding this comment.
how should the user execute this step?
yongenaelf
reviewed
Jan 2, 2025
| }, | ||
| sideChainSmartContract: IContract | ||
| ): Promise<number> => { | ||
| // @ts-ignore |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`fetchNftBalances`** function with this code snippet: | ||
|
|
||
| ```javascript title="commonFunctions.ts" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`fetchUserNftData`** function with this code snippet: | ||
|
|
||
| ```javascript title="commonFunctions.ts" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`getNFTData`** function with this code snippet: | ||
|
|
||
| ```javascript title="home/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| - Replace the existing **`getNFTData`** function with this code snippet: | ||
|
|
||
| ```javascript title="profile/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| #### Install necessary packages and libraries | ||
|
|
||
| - Run teh following command in the terminal: |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the form variable with this code snippet: | ||
|
|
||
| ```javascript title="transfer-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the form variable with this code snippet: | ||
|
|
||
| ```javascript title="transfer-nft/index.tsx" |
yongenaelf
reviewed
Jan 2, 2025
|
|
||
| 2. Replace the form variable with this code snippet: | ||
|
|
||
| ```javascript title="" |
There was a problem hiding this comment.
ts
remove title="" if no title is needed
yongenaelf
reviewed
Jan 2, 2025
| 2. **Parameters:** It takes `values`, which is inferred from the `formSchema` and represents the form's data. | ||
| 3. **Calls Transfer Function:** It calls the `transferNftToOtherAccount` function with the form values to initiate the NFT transfer. | ||
|
|
||
| Now that we've written all the necessary frontend functions and components, we're ready to run the NFT dApp application in the next step. |
There was a problem hiding this comment.
dApp stands for "decentralised application", no need to add "application" after "dApp"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.