Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO replace to_allocvec with an incremental buffer in the LLMP manager #1082

Closed
andreafioraldi opened this issue Feb 17, 2023 · 2 comments · Fixed by #2794
Closed

TODO replace to_allocvec with an incremental buffer in the LLMP manager #1082

andreafioraldi opened this issue Feb 17, 2023 · 2 comments · Fixed by #2794
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andreafioraldi
Copy link
Member

Just noticed that we do useless allocations
@andreafioraldi andreafioraldi added the enhancement New feature or request label Feb 17, 2023
@domenukk domenukk added the good first issue Good for newcomers label Mar 15, 2024
@UtkarshTiwari1750
Copy link

Is this issue still open?
I would like to work on it.

@domenukk
Copy link
Member

Be aware that a quite a few things might have changed in that code but yes it's still open

mzfr pushed a commit to mzfr/LibAFL that referenced this issue Dec 28, 2024
Optimize event serialization with pre-allocated buffer
c06ba0d 
- Added event_buffer field to LlmpEventManager
- Used to_slice instead of to_allocvec
- Pre-allocated buffer size is 4KB

Fixes AFLplusplus#1082
mzfr added a commit to mzfr/LibAFL that referenced this issue Dec 28, 2024
@mzfr
Optimize event serialization with pre-allocated buffer
c016c7f 
- Added event_buffer field to LlmpEventManager
- Used to_slice instead of to_allocvec
- Pre-allocated buffer size is 4KB

Fixes AFLplusplus#1082
@mzfr mzfr mentioned this issue Dec 28, 2024
Merged
domenukk pushed a commit that referenced this issue Dec 30, 2024
@mzfr
Optimize event serialization with pre-allocated buffer (#2794)
8cd069c 
* Optimize event serialization with pre-allocated buffer

- Added event_buffer field to LlmpEventManager
- Used to_slice instead of to_allocvec
- Pre-allocated buffer size is 4KB

Fixes #1082

* Fallback to to_allocvec in case of event_buffer overflow

Also combined the shared logic between compressed & uncompressed event
firing while keeping the same behavior

* Made the initial event_buffer size to a const

Also removed the unnecessary event_buffer.clear(), since we are already
resizing it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize event serialization with pre-allocated buffer mzfr/LibAFL
3 participants
@domenukk @andreafioraldi @UtkarshTiwari1750