Support on_crash & on_timeout callbacks for libafl_qemu modules #2620
+187
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazeballs |
domenukk
reviewed
Oct 17, 2024
libafl_qemu/src/modules/drcov.rs
Outdated
| self.write(); | ||
| } | ||
|
|
||
| fn on_crash(&mut self) { |
There was a problem hiding this comment.
Only question is, should the callbacks have access to input, state etc.?
There was a problem hiding this comment.
i started to implement this with these things as parameters, but i realized that for now it doesn't seem useful.
so i was planning to add these if it is needed later on
|
there should be a comment stating that "Never do something that could crash inside crash handler". I've at least seen twice when such mistake is made into libafl. |
|
yes that's right, i'll add this |
|
i'll even make them unsafe, it's easy to mess up in there |
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly useful for drcov stuff for now.
should solve #1150