Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter Duplicate Input Execution #2771
Filter Duplicate Input Execution #2771
Changes from all commits
aefb8e3
a98c981
7acf5a3
2da6dc5
1e571a0
d020b9e
e1d0b92
c842eda
31d9b56
c9eb2a8
93b64f9
294d2f1
c170986
bab9890
71fc1c6
a2fa10c
30e1db4
025a56a
63b9ac9
92c3f08
6395df9
17c63fe
61120bf
8757a33
6d1090d
ff0a25b
d193c06
d16ede3
c6f5646
4275e0c
28b5c4a
60e188f
68041b9
e3f530e
db994a4
d2dc266
bdade95
d2fda6b
01c91fe
0e99d38
40aa07c
3499e64
06499cd
22f98eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this I: Hash necessary? if not can you delete?
(always, keep the contraints minimal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the bloom filter checks presence based on the hash value of the input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a
with_input_filter
method and then you just provide aBloomInputFilter
there (or we keep this one as extra constructor)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a generic version and changed both
new
andwith_bloom_input_filter
to use this one.