Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting data into data batches #24

Open
arunoruto opened this issue Feb 15, 2024 · 3 comments
Open

Splitting data into data batches #24

arunoruto opened this issue Feb 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@arunoruto
Copy link
Contributor

Currently, the particle_interaction function implemented on GPU is taking the whole dataset. This can lead to out of memory errors, especially on GPUs with less VRAM. To mitigate this problem, the data should be batched into smaller chunks before processing!

This should be addressed by calculating the needed and available memory on the GPU. Dividing these two values gives a lower bound on the number of batches to divide the dataset into.

@arunoruto arunoruto self-assigned this Feb 15, 2024
@arunoruto
Copy link
Contributor Author

Two approaches:

  • Static dividing of the data based on the total VRAM size of the GPU. This gives the index values to be passed down for calculation.
  • Dynamically determine how much space is left on the GPU and generate the index list. The number of elements of the index list changes every time, depending on how much the GPU is utilized.

@arunoruto arunoruto added bug Something isn't working enhancement New feature or request labels Mar 20, 2024
@aetherspritee aetherspritee pinned this issue Mar 23, 2024
@aetherspritee
Copy link
Collaborator

check #38

arunoruto added a commit that referenced this issue Mar 29, 2024
add batching functionality, plus some small fixes (#24)
@arunoruto
Copy link
Contributor Author

Currently, only the phase function is batched due to the large number of angles that sometimes require calculation. The approach should be generalized further for other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants