Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises and ts1.6 (fixes #18, fixes #22) #20

Merged
merged 7 commits into from
Sep 29, 2015

Conversation

fredgalvao
Copy link
Contributor

  • Fixed keys definition (allDocs({keys: ['a', 'b']}))
  • Made it compatible with typescript 1.6 (1.6.2)
  • Made it work with external Promise implementations/definitions
  • Prettified the main files as per standard VSCode style
  • Fixed some UTF-8 ghosts

This one closes #18 and #19

Let me know if you need anything else related to these.

@fredgalvao
Copy link
Contributor Author

Tests are failing because of #4, tsc 1.6 actually gets these things now.

@AGBrown AGBrown changed the title Promises and ts1.6 Promises and ts1.6 (fixed #18, fixed #22) Sep 29, 2015
@AGBrown AGBrown changed the title Promises and ts1.6 (fixed #18, fixed #22) Promises and ts1.6 (fixes #18, fixed #22) Sep 29, 2015
@AGBrown AGBrown changed the title Promises and ts1.6 (fixes #18, fixed #22) Promises and ts1.6 (fixes #18, fixes #22) Sep 29, 2015
@AGBrown
Copy link
Owner

AGBrown commented Sep 29, 2015

After splitting some of the smaller parts of this into #24, #26 (both part of #25) and #19, this PR now focuses on #18 and #22.

👍

AGBrown added a commit that referenced this pull request Sep 29, 2015
#18 Use standard es6 (or any user supplied) promise interface.
fixes #18, fixes #22
@AGBrown AGBrown merged commit 785d5d1 into AGBrown:master Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make definitions work nicely with third-party promise implementations
2 participants