Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-crypt merge driver to support secret files merging (refactored #107) #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jirutka
Copy link

@jirutka jirutka commented Jul 28, 2019

This PR is a refactoring of PR #107. The original PR mixes multiple unrelated changes in a single commit, including some maybe unwanted changes and code-style violations, which is probably the reason why it’s still not merged.

This PR contains only and only the changes needed for the merge driver support with minimum changes to the existing code (separated into an extra commit), so it should be easy for review. I’ve also fixed a few shortcomings in the original PR.

jirutka and others added 2 commits July 28, 2019 20:28
This is a preparation for the merge command.

I've extracted this change from AGWA#107.

Co-Authored-By: Shlomo Shachar <shlomo.shachar@binatix.com>
This commit is based on AGWA#107.

Co-Authored-By: Shlomo Shachar <shlomo.shachar@binatix.com>
@brandsimon
Copy link

Will this fix git add -p?

@rpasche
Copy link

rpasche commented Nov 2, 2019

Any news here? I would love to see this merged but I also have to test it myself.

@Quentin-M
Copy link

Quentin-M commented Feb 22, 2021

Couple of years since my last comment on this feature.. Any plan to merge @AGWA? :)

For anyone lurking, @jirutka's solution works like a charm - simply compile it, place it in your PATH and git-crypt unlock again which will update your .git/config with the proper [merge "git-crypt{-<key>}"] blocks and allow for git rebase and git merge.

@joaosa
Copy link

joaosa commented Mar 3, 2021

@AGWA This would be incredibly useful, as it addresses a common hinderance to using git-crypt. Is there any chance this could get merged? :)

@YellowOnion
Copy link

Maybe someone else can take over maintaining the project, There's 21 pull requests open, and this one is basically an essential feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants