Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update build.gradle #21

wants to merge 1 commit into from

Conversation

cptully
Copy link

@cptully cptully commented Dec 22, 2023

Added xmlpull dependency

At least when I added cql-testing to my my package.json at work, I had to hack the node_modules/cql-testing/build.gradle file as I have done in this PR.

Added xmlpull dependency
@cmoesel
Copy link
Collaborator

cmoesel commented Jan 2, 2024

Interesting. I am able to run npm run cql-to-elm fine on the master branch (without this change). I am using Java 11 and the supplied gradlew script (which is Gradle 8.4) on Mac. What version of Java / Gradle are you running?

@cmoesel
Copy link
Collaborator

cmoesel commented Jan 2, 2024

Ah wait. But I see now that you added this as a dependency to another package (not running it directly from this project). I will try that too. Maybe that introduces a change.

@cmoesel
Copy link
Collaborator

cmoesel commented Jan 3, 2024

As discussed on chat.fhir.org, the current release (without this change) works for me when I integrate it into a separate project (using Java 11, 17, and 21) -- so I'm not able to reproduce the issue.

That said, I can see here where the translator team made changes to the xpp dependency and removed it from the runtime for the CLI. And I actually had to do this when I upgraded the Translation Service to use the 3.x translator -- so I guess I should have seen this coming. But I still don't understand why the CQL Testing cql-to-elm is working fine for me. Based on that, I had assumed that the cql-to-elm-cli package included xpp somehow (otherwise, how does it work at all?).

It looks like when the translator team needs an xpp implementation, they use org.ogce:xpp3:1.1.6, so perhaps we should use that instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants