Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to sample before tokenize #26

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Refactor to sample before tokenize #26

merged 1 commit into from
Apr 2, 2024

Conversation

morgandu
Copy link
Contributor

@morgandu morgandu commented Apr 2, 2024

No description provided.

@morgandu morgandu requested a review from vipannalla as a code owner April 2, 2024 00:30
@morgandu morgandu requested review from JoeZijunZhou and removed request for vipannalla April 2, 2024 00:30
JoeZijunZhou
JoeZijunZhou approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@JoeZijunZhou JoeZijunZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@morgandu morgandu merged commit 5820c95 into main Apr 2, 2024
3 checks passed
@morgandu morgandu deleted the mor--benchmark branch April 2, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeZijunZhou JoeZijunZhou JoeZijunZhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morgandu @JoeZijunZhou