move tokenizer model to third party llama2 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZijunZhou
approved these changes
Apr 3, 2024
patemotter
approved these changes
Apr 3, 2024
| @@ -48,7 +48,7 @@ def decode(self, t: int) -> str: | |||
|
|
|||
| class TokenUtilsTest(unittest.TestCase): | |||
| def setup(self): | |||
| tokenizer_path = "tokenizer.model" | |||
| tokenizer_path = "third_party/llama2/tokenizer.model" | |||
| current_dir = os.path.dirname(__file__) | |||
| tokenizer_path = os.path.join(current_dir, tokenizer_path) | |||
| print(f"model_path: {tokenizer_path}") | |||
There was a problem hiding this comment.
Nit outside of this change: Should probably be renamed to tokenizer_path.
Also typos in comments above "Tokenier" -> "Tokenizer"
There was a problem hiding this comment.
Thanks Pate! there could be more data set from llama2. Keep it as "third_party/llama2"
The test_underscore_in_output test is specific for a under score token id, it may fail if tokenizer changed. All other 3 test are tokenizer independent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move tokenizer model to third party llama2