-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile and entrypoint script for the jetstream-pytorch-server #203
Add Dockerfile and entrypoint script for the jetstream-pytorch-server #203
Conversation
b647a9a
to
a1b9cd9
Compare
/usr/bin/python3 python3 /usr/bin/python3.10 1 | ||
|
||
|
||
RUN git clone https://github.com/AI-Hypercomputer/JetStream.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line. Jetstream is installed as part of install_everything.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JetStream is part of install_everything.sh
but its reference is an older version. For our use case, we just want to build off of main for both JetStream and jetstream-pytorch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see, if that is the desire, then, we need to update the version that jetstream-pytorch
pins. Because the CIs is running this version otherwise it is not guaranteed to work ( especially when the proto definition changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do that in the same PR. do cd deps/JetStream
then git pull
then git checkout <hash or tag or branch>
. Then go back to the root and commit the submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, updated the JetStream dependency
|
||
RUN pip install -U jax[tpu]==0.4.35 -f https://storage.googleapis.com/jax-releases/libtpu_releases.html | ||
|
||
RUN cd /JetStream && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, updated JetStream dependency above and updated the jax version in install_everything.sh
7fedde3
to
c60a312
Compare
c60a312
to
39e9fcf
Compare
Adds a Dockerfile and entrypoint script to build the jetstream-pytorch-server image for inference. This is to consolidate artifacts to build out the JetStream-PyTorch artifact in the jetstream-pytorch repository. Adding the Dockerfile here will help to build out our internal pipeline for model server image release, as right now, the components here are referenced as part of a tutorial.