Move deps to git submodule #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
force-pushed
the
hanq_dev
branch
2 times, most recently
from
2ffafbd to
2a512a4
Compare
FanhaiLu1
reviewed
May 17, 2024
| @@ -0,0 +1,6 @@ | |||
| [submodule "deps/JetStream"] | |||
There was a problem hiding this comment.
Does it mean the default is head? In automation test or integration test, we would need the tag or commit id for the project.
There was a problem hiding this comment.
the default is this hash:
To update this hash one ch's into the directory and run git pull .. etc.
wang2yn84
reviewed
May 17, 2024
| @@ -158,20 +158,15 @@ def main(argv): | |||
| decode_state, result_tokens = engine.generate(params, decode_state) | |||
| result_tokens = result_tokens.convert_to_numpy() | |||
| res = result_tokens.get_result_at_slot(slot) | |||
| stop_tokens = set(tokenizer.tokenizer.stop_tokens) | |||
| stop_tokens = set(tokenizer.stop_tokens) | |||
There was a problem hiding this comment.
JetStream didn't implement the stop_tokens for SentencePiece. You might need to add that function to JetStream.
There was a problem hiding this comment.
| # print(Fore.GREEN + output_str, end="", flush=True) | ||
|
|
||
| # print(Style.RESET_ALL + "\n") | ||
| # print("---- Streaming decode finished.") | ||
|
|
||
| print("---- All output tokens.") | ||
| print(sampled_tokens_list) |
There was a problem hiding this comment.
I tried in my local, actually the decode function doesn't work. Not sure if it's my local env or not.
FanhaiLu1
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.