Enable orbax cloud logger by default. #1034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavclemson
requested review from
gobbleturk,
jonb377,
khatwanimohit,
bvandermoon and
vipannalla
as code owners
| @@ -446,8 +446,7 @@ enable_jax_profiler: False | |||
| jax_profiler_port: 9999 | |||
|
|
|||
| # Checkpoint Structured logging | |||
| enable_checkpoint_cloud_logger: False | |||
| enable_checkpoint_standard_logger: False | |||
| enable_checkpoint_cloud_logger: True | |||
There was a problem hiding this comment.
Would it ever make sense to set this to False. If not then I would prefer removing the config option and not have a check in setting up the cloud logger
There was a problem hiding this comment.
Few reasons:
- Sometimes too much logging can cause performance issues.
- If Cloud logging starts breaking the training, issues like cloud monitoring api RATE_LIMIT exceeding.
- Moreover, like Goodput(which is utilising cloud logging) we should give user option to turn it off.
There was a problem hiding this comment.
Thanks for explaining!
khatwanimohit
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.