Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a PR description template to MaxText #1060

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

shralex
Copy link
Collaborator

@shralex shralex commented Nov 24, 2024

This PR adds a template for PR descriptions, aimed to provide sufficient details about the changes being made.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@gobbleturk gobbleturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah awesome! Thanks Alex!!

@shralex shralex force-pushed the shralex_pr_template branch 2 times, most recently from 5651053 to 98d8df7 Compare November 24, 2024 01:51
Copy link
Collaborator

@gobbleturk gobbleturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Alex!!

Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Alex!

@copybara-service copybara-service bot merged commit 0c2f0d1 into main Nov 25, 2024
15 checks passed
@copybara-service copybara-service bot deleted the shralex_pr_template branch November 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants