Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'model_name' label to metrics #1195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 'model_name' label to metrics #1195

wants to merge 1 commit into from

Conversation

Bslabe123
Copy link
Collaborator

@Bslabe123 Bslabe123 commented Jan 23, 2025 •
edited
Loading

Description

Pass model name to metrics server config

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@Bslabe123 Bslabe123 force-pushed the metrics-model-label-new branch from 428ff97 to 564887b Compare January 23, 2025 23:44
@Bslabe123 Bslabe123 force-pushed the metrics-model-label-new branch 2 times, most recently from 4325211 to 0d8cf2e Compare January 24, 2025 18:09
@Bslabe123 Bslabe123 force-pushed the metrics-model-label-new branch from 0d8cf2e to c0ac14e Compare January 24, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipannalla vipannalla vipannalla approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bslabe123 @vipannalla