Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paged Attention #1206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Paged Attention #1206

wants to merge 1 commit into from
+1,759 −48

Conversation

patemotter
Copy link
Collaborator

Description

Adds paged attention functionality. Can be enabled using the attention=paged flag. This code is functional for certain cases, but not optimized yet. This code should not be used for production purposes at this point.

Tests

  • Unit tests, including newly added paged attention tests.
  • Microbenchmarks
  • Running decode script

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@patemotter patemotter force-pushed the patemotter_paged_attention branch 7 times, most recently from 37bd7bf to f236348 Compare January 30, 2025 00:03
@patemotter patemotter force-pushed the patemotter_paged_attention branch from f236348 to ba264b2 Compare January 30, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patemotter