Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to remove preview tag. #1252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md to remove preview tag. #1252

wants to merge 2 commits into from
+2 −2

Conversation

yangyuwei
Copy link
Collaborator

Description

Remove "preview" from MaxText README.md (https://github.com/AI-Hypercomputer/maxtext/blob/main/README.md).

FIXES: b/395188661

Tests

This is a change to the doc. No impact to the tests.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@yangyuwei yangyuwei requested a review from richjames0 February 8, 2025 01:19
richjames0
richjames0 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yangyuwei yangyuwei marked this pull request as ready for review February 10, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richjames0 richjames0 richjames0 approved these changes

@gobbleturk gobbleturk gobbleturk approved these changes

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangyuwei @richjames0 @gobbleturk