Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Workload Identity and GCSFuse driver flags added. #177

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

sharabiani
Copy link
Collaborator

Fixes / Features

  • --enable-workload-identity flag implemented for `cluster create' command. It enables Workload Identity Federation on the cluster and node-pools.
  • --enable-gcsfuse-csi-driver flag implemented for `cluster create' command. It enables GSCFuse driver on the cluster. This also enables Workload Identity Federation.'

Testing / Documentation

Manual tests.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@sharabiani sharabiani marked this pull request as draft August 21, 2024 12:17
Copy link
Collaborator

@Obliviour Obliviour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great changes! I have some questions about --enable-workload-identity support by itself and some nits!

src/xpk/commands/cluster.py Outdated Show resolved Hide resolved
src/xpk/parser/cluster.py Show resolved Hide resolved
src/xpk/core/core.py Show resolved Hide resolved
@sharabiani sharabiani self-assigned this Aug 29, 2024
@sharabiani sharabiani marked this pull request as ready for review August 29, 2024 12:51
@PBundyra
Copy link
Collaborator

PBundyra commented Sep 3, 2024

LGTM

@sharabiani sharabiani merged commit 01a4b53 into development Sep 4, 2024
6 checks passed
@sharabiani sharabiani deleted the enable-WI-development branch September 4, 2024 22:55
PBundyra pushed a commit that referenced this pull request Sep 25, 2024
* Enabling Workload Identity and GCSFuse driver flags added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants