Add Zarr Flag for Pathways #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingthor
reviewed
Aug 26, 2024
| @@ -51,7 +51,8 @@ def get_pathways_worker_args(args) -> str: | |||
| - --xla_tpu_enable_async_collective_fusion_multiple_steps=true | |||
| - --xla_tpu_overlap_compute_collective_tc=true | |||
| - --xla_enable_async_all_gather=true | |||
| - --pathways_tmp_dir_pattern={args.pathways_gcs_location}""" | |||
| - --pathways_tmp_dir_pattern={args.pathways_gcs_location} | |||
| - --pathways_experimental_suspend_storage_mode=BACKEND_TENSORSTORE""" # This is to enable zarr for pathways. When OCDBT is tested, remove this flag | |||
There was a problem hiding this comment.
You do not need to change the PW workers here. Unless you want this flag to be consistent between the 2 jobs, you could remove this flag here.
mingthor
reviewed
Aug 26, 2024
| @@ -215,7 +216,8 @@ def get_pathways_rm_args(args, system: SystemCharacteristics) -> str: | |||
| - --pathways_device_type=NONE | |||
| - --pathways_persistent_compilation_cache=false | |||
| - --pathways_tmp_dir_pattern={args.pathways_gcs_location} | |||
| - --pathways_expected_instances={expected_instances}""" | |||
| - --pathways_expected_instances={expected_instances} | |||
| - --pathways_experimental_suspend_storage_mode=BACKEND_TENSORSTORE""" # This is to enable zarr for pathways. When OCDBT is tested, remove this flag | |||
There was a problem hiding this comment.
Rename "Zarr" to "vanilla TensorStore" in the comment?
|
Resolved with internal changes instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.