Add support for automatic cleanup of jobsets #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obliviour
requested review from
44past4,
sharabiani,
pawloch00 and
BluValor
as code owners
pawloch00
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
I ran two workloads on TPUs one with --ttl-seconds-after-finished=0 and the other without the flag, I see the jobset yaml having the new flag in it and i see in the --ttl-seconds-after-finished=0 case that the workload immediately is removed after completion.
This is important for avoiding overloading the api server (jobset manager) with old jobsets that are no longer needed.