feature: support custom headers for LLM call when using custom embedding#62
Merged
planetf1 merged 3 commits intoAI4quantum:mainfrom Sep 9, 2025
Merged
feature: support custom headers for LLM call when using custom embedding#62planetf1 merged 3 commits intoAI4quantum:mainfrom
planetf1 merged 3 commits intoAI4quantum:mainfrom
Conversation
3ccc3eb to
f1ff590
Compare
Collaborator
Author
|
I had to add 4 type corrections in the milvus test that were added in a previous PR (unrelated to this change) - lint now runs cleanly |
3f71d04 to
027ec2e
Compare
Collaborator
Author
|
Parsing of environment in start.sh was also fixed to be more robust with quoted values |
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
499a6b4 to
917faac
Compare
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
ajbozarth
approved these changes
Sep 8, 2025
Member
ajbozarth
left a comment
There was a problem hiding this comment.
Tested local using RITS and this LGTM.
One big caveat: You need to remove the cli changes and open a PR on the new repo with those instead since it got moved out after you opened this
Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
Collaborator
Author
|
Removed cli changes. Will open issue on new cli repo. |
Collaborator
Author
|
Raised issue AI4quantum/maestro-cli#3 for cli changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support when specifying custom headers when using CUSTOM_EMBEDDING_MODEL & associated parameters
milvus only (only milvus supports custom embeddings)
Example:
or
Alternatively multiple values can be comma separated, or the variable can be specified in JSON
Tested on a platform which requires custom headers for authentication
Fixes #61