Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Don't fail when system partition and reserved size are defined #7

Open
wants to merge 1 commit into
base: p9.0
Choose a base branch
from

Conversation

Preet23
Copy link

@Preet23 Preet23 commented Nov 25, 2018

When BOARD_SYSTEMIMAGE_PARTITION_SIZE and
BOARD_SYSTEMIMAGE_PARTITION_RESERVED_SIZE are both defined, the build
will fail since it's defined in treble's common makefiles.

To avoid this, if the device has a custom system partition size
specified, set the reserved size to nothing and use the system partition
size instead. Be sure to warn the build user of this change

Taken from:- CypherOS/build@7bdc901

When BOARD_SYSTEMIMAGE_PARTITION_SIZE and
BOARD_SYSTEMIMAGE_PARTITION_RESERVED_SIZE are both defined, the build
will fail since it's defined in treble's common makefiles.

To avoid this, if the device has a custom system partition size
specified, set the reserved size to nothing and use the system partition
size instead. Be sure to warn the build user of this change

Taken from:- CypherOS/build@7bdc901
@yyl3866
Copy link

yyl3866 commented Apr 22, 2024

https://github.com/AOSP-KONA-MSMNILE-LAHAINA-KALAMA/device_xiaomi_cmi/tree/thirteen

[100% 1/1] analyzing Android.bp files and generating ninja file at out/soong/build.ninja
FAILED: out/soong/build.ninja
cd "$(dirname "out/host/linux-x86/bin/soong_build")" && BUILDER="$PWD/$(basename "out/host/linux-x86/bin/soong_build")" && cd / && env -i "$BUILDER" --top "$TOP" --so ong_out "out/soong" --out "out" -o out/soong/build.ninja --globListDir build --globFile out/soong/globs-build.ninja -t -l out/.module_paths/Android.bp.list --available _env out/soong/soong.environment.available --used_env out/soong/soong.environment.used.build Android.bp
error: vendor/aicp/build/soong/Android.bp:24:8: module "generated_kernel_includes": cmd: unknown variable '$(PATH_OVERRIDE_SOONG)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants